Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate EventWaveform class #1940

Draft
wants to merge 3 commits into
base: nwb_schema_2.8.0
Choose a base branch
from
Draft

Deprecate EventWaveform class #1940

wants to merge 3 commits into from

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 23, 2024 •
edited
Loading

Motivation

Corresponds to NeurodataWithoutBorders/nwb-schema#584

  • Waiting on test suite to pass
  • Waiting on schema changes to merge to dev

How to test the behavior?

EventWaveform()  # should return a ValueError

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (dc98e84) to head (92643d4).

Files with missing lines Patch % Lines
src/pynwb/ecephys.py 66.66% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (dc98e84) and HEAD (92643d4). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (dc98e84) HEAD (92643d4)
integration 4 0
Additional details and impacted files 
@@                 Coverage Diff                  @@
##           nwb_schema_2.8.0    #1940      +/-   ##
====================================================
- Coverage             91.85%   83.28%   -8.58%     
====================================================
  Files                    27       27              
  Lines                  2689     2692       +3     
  Branches                701      702       +1     
====================================================
- Hits                   2470     2242     -228     
- Misses                  145      352     +207     
- Partials                 74       98      +24
Flag Coverage Δ
integration ?
unit 83.28% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly changed the base branch from dev to nwb_schema_2.8.0 September 20, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rly